diff --git a/DESCRIPTION b/DESCRIPTION index d554bd86..4286641f 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: AMR -Version: 0.9.0.9020 -Date: 2020-02-09 +Version: 0.9.0.9021 +Date: 2020-02-10 Title: Antimicrobial Resistance Analysis Authors@R: c( person(role = c("aut", "cre"), diff --git a/NEWS.md b/NEWS.md index 5a0bbf56..7875dfcc 100755 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,5 @@ -# AMR 0.9.0.9020 -## Last updated: 09-Feb-2020 +# AMR 0.9.0.9021 +## Last updated: 10-Feb-2020 ### New * Support for LOINC and SNOMED codes diff --git a/R/disk.R b/R/disk.R index a9a470d7..db6dfd5d 100644 --- a/R/disk.R +++ b/R/disk.R @@ -81,7 +81,7 @@ as.disk <- function(x, na.rm = FALSE) { #' @export #' @importFrom dplyr %>% is.disk <- function(x) { - class(x) %>% identical(c("disk", "integer")) + inherits(x, c("disk", "integer")) } #' @exportMethod print.disk diff --git a/R/mic.R b/R/mic.R index ced778bf..f2aacc82 100755 --- a/R/mic.R +++ b/R/mic.R @@ -130,7 +130,7 @@ as.mic <- function(x, na.rm = FALSE) { #' @export #' @importFrom dplyr %>% is.mic <- function(x) { - class(x) %>% identical(c("mic", "ordered", "factor")) + inherits(x, c("mic", "factor")) } #' @exportMethod as.double.mic diff --git a/R/rsi.R b/R/rsi.R index cb765618..d3b377c7 100755 --- a/R/rsi.R +++ b/R/rsi.R @@ -346,8 +346,7 @@ as.rsi.data.frame <- function(x, col_mo = NULL, guideline = "EUCAST", ...) { #' @rdname as.rsi #' @export is.rsi <- function(x) { - identical(class(x), - c("rsi", "ordered", "factor")) + inherits(x, c("rsi", "factor")) } #' @rdname as.rsi diff --git a/docs/404.html b/docs/404.html index caa5c3d8..6d127bbc 100644 --- a/docs/404.html +++ b/docs/404.html @@ -84,7 +84,7 @@
diff --git a/docs/LICENSE-text.html b/docs/LICENSE-text.html index 61e6bb74..27b2720b 100644 --- a/docs/LICENSE-text.html +++ b/docs/LICENSE-text.html @@ -84,7 +84,7 @@ diff --git a/docs/articles/benchmarks.html b/docs/articles/benchmarks.html index 0f0c5764..88deea93 100644 --- a/docs/articles/benchmarks.html +++ b/docs/articles/benchmarks.html @@ -41,7 +41,7 @@ @@ -187,7 +187,7 @@benchmarks.Rmd
In the table above, all measurements are shown in milliseconds (thousands of seconds). A value of 5 milliseconds means it can determine 200 input values per second. It case of 100 milliseconds, this is only 10 input values per second.
To achieve this speed, the as.mo
function also takes into account the prevalence of human pathogenic microorganisms. The downside of this is of course that less prevalent microorganisms will be determined less fast. See this example for the ID of Methanosarcina semesiae (B_MTHNSR_SEMS
), a bug probably never found before in humans:
That takes 5.6 times as much time on average. We can conclude that looking up arbitrary codes of less prevalent microorganisms is the worst way to go, in terms of calculation performance. Full names (like Methanosarcina semesiae) are always very fast and only take some thousands of seconds to coerce - they are the most probable input from most data sets.
In the figure below, we compare Escherichia coli (which is very common) with Prevotella brevis (which is moderately common) and with Methanosarcina semesiae (which is uncommon):
@@ -308,8 +293,8 @@ print(run_it, unit = "ms", signif = 3) # Unit: milliseconds # expr min lq mean median uq max neval -# mo_name(x) 574 626 649 644 660 787 100 -So transforming 500,000 values (!!) of 50 unique values only takes 0.64 seconds (643 ms). You only lose time on your unique input values.
+# mo_name(x) 566 598 628 621 645 782 100 +So transforming 500,000 values (!!) of 50 unique values only takes 0.62 seconds (620 ms). You only lose time on your unique input values.
So going from mo_name("Staphylococcus aureus")
to "Staphylococcus aureus"
takes 0.0008 seconds - it doesn’t even start calculating if the result would be the same as the expected resulting value. That goes for all helper functions:
So going from mo_name("Staphylococcus aureus")
to "Staphylococcus aureus"
takes 0.0009 seconds - it doesn’t even start calculating if the result would be the same as the expected resulting value. That goes for all helper functions:
run_it <- microbenchmark(A = mo_species("aureus"),
B = mo_genus("Staphylococcus"),
C = mo_name("Staphylococcus aureus"),
@@ -338,14 +323,14 @@
print(run_it, unit = "ms", signif = 3)
# Unit: milliseconds
# expr min lq mean median uq max neval
-# A 0.451 0.485 0.488 0.489 0.495 0.518 10
-# B 0.507 0.510 0.526 0.522 0.538 0.554 10
-# C 0.732 0.742 0.769 0.781 0.786 0.807 10
-# D 0.507 0.514 0.534 0.531 0.549 0.585 10
-# E 0.469 0.486 0.492 0.489 0.499 0.532 10
-# F 0.473 0.479 0.483 0.481 0.482 0.513 10
-# G 0.466 0.469 0.481 0.480 0.486 0.517 10
-# H 0.468 0.476 0.502 0.483 0.494 0.665 10
Of course, when running mo_phylum("Firmicutes")
the function has zero knowledge about the actual microorganism, namely S. aureus. But since the result would be "Firmicutes"
anyway, there is no point in calculating the result. And because this package ‘knows’ all phyla of all known bacteria (according to the Catalogue of Life), it can just return the initial value immediately.
Currently supported are German, Dutch, Spanish, Italian, French and Portuguese.
diff --git a/docs/articles/benchmarks_files/figure-html/unnamed-chunk-4-1.png b/docs/articles/benchmarks_files/figure-html/unnamed-chunk-4-1.png index b5e3e534..2398f800 100644 Binary files a/docs/articles/benchmarks_files/figure-html/unnamed-chunk-4-1.png and b/docs/articles/benchmarks_files/figure-html/unnamed-chunk-4-1.png differ diff --git a/docs/articles/benchmarks_files/figure-html/unnamed-chunk-6-1.png b/docs/articles/benchmarks_files/figure-html/unnamed-chunk-6-1.png index 345118f4..9bd84173 100644 Binary files a/docs/articles/benchmarks_files/figure-html/unnamed-chunk-6-1.png and b/docs/articles/benchmarks_files/figure-html/unnamed-chunk-6-1.png differ diff --git a/docs/articles/index.html b/docs/articles/index.html index e1540098..326df2ec 100644 --- a/docs/articles/index.html +++ b/docs/articles/index.html @@ -84,7 +84,7 @@ diff --git a/docs/authors.html b/docs/authors.html index 95aaec11..91c14c70 100644 --- a/docs/authors.html +++ b/docs/authors.html @@ -84,7 +84,7 @@ diff --git a/docs/index.html b/docs/index.html index 9c353d20..bbf424f8 100644 --- a/docs/index.html +++ b/docs/index.html @@ -45,7 +45,7 @@ diff --git a/docs/news/index.html b/docs/news/index.html index a51a68f4..dc9f9400 100644 --- a/docs/news/index.html +++ b/docs/news/index.html @@ -84,7 +84,7 @@ @@ -231,13 +231,13 @@ -as.mo(..., allow_uncertain = 3)
Contents